Add JSpecify nullable annotations to exception classes #16027
Conversation
selenium-ci
added
B-grid
|
Thank you, @iampopovich for this code suggestion. The support packages contain example code that many users find helpful, but they do not necessarily represent We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks. |
|
i guess there are too many similar PRs for the changes. i'll try open one another later |
|
oh. i see now |
🔗 Related Issues
partially fixes #14291
💥 What does this PR do?
same as
#16024
#16025
#16026
🔧 Implementation Notes
This pull request introduces updates to several exception classes across the Selenium codebase to improve null-safety and enhance clarity. The changes primarily involve adding
@NullMarkedannotations to the classes and@Nullableannotations to method parameters where applicable.Null-safety improvements:
java/src/org/openqa/selenium/devtools/RequestFailedException.java: Added@NullMarkedannotation to the class to enforce null-safety.java/src/org/openqa/selenium/grid/sessionmap/jdbc/JdbcException.java: Added@NullMarkedannotation to the class and@Nullableannotations to method parameters (messageandcause) to handle potential null values.java/src/org/openqa/selenium/remote/NoSuchDriverException.java: Added@NullMarkedannotation to the class and updated constructors to include@Nullableannotations forreasonandcauseparameters.java/src/org/openqa/selenium/remote/UnreachableBrowserException.java: Added@NullMarkedannotation to the class and updated constructors with@Nullableannotations formessageandcauseparameters.java/src/org/openqa/selenium/support/ui/UnexpectedTagNameException.java: Added@NullMarkedannotation to the class and updated the constructor to include@Nullableannotations forexpectedTagNameandactualTagNameparameters.💡 Additional Considerations
🔄 Types of changes